third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h - Issue 1813483002: ImagePixelLocker now manually allocates SkPixmap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h

Issue 1813483002: ImagePixelLocker now manually allocates SkPixmap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp » ('j') | third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h

diff --git a/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h b/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h

index 3b486dfe375deaba7086108fc93393f9376f7f43..e6d0fbd5610173c43574f0c34028e2f54e8237a4 100644

--- a/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h

+++ b/third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h

@@ -22,13 +22,14 @@ class ImagePixelLocker final {

WTF_MAKE_NONCOPYABLE(ImagePixelLocker);

public:

ImagePixelLocker(PassRefPtr<const SkImage>, SkAlphaType, SkColorType);

+ ~ImagePixelLocker();

const void* pixels() const { return m_pixels; }

private:

const RefPtr<const SkImage> m_image;

const void* m_pixels;

- SkAutoPixmapStorage m_pixelStorage;

+ SkPixmap m_pixelStorage;

f(malita) 2016/03/16 19:28:29 Let's rename this to m_pixmap.

robertphillips 2016/03/16 19:59:10 It is actually back to being more of a pure pixel

};

} // namespace blink