Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1813453002: S390: Add Printf format specifier (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Add Printf format specifier GCC on S390 31-bit treats size_t as 'long unsigned int', which is incompatible with %d format specifier that expects an 'int'. Introduce a new V8 SIZET PREFIX to use %zd instead. R=danno@chromium.org,jkummerow@chromium.org,jochen@chromium.org,jyan@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,yangguo@chromium.org BUG= Committed: https://crrev.com/da8b4fa7ed1e17910254cae7c3706c46f6fbc997 Cr-Commit-Position: refs/heads/master@{#34857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/profiler/allocation-tracker.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
S390: Add Printf format specifier
4 years, 9 months ago (2016-03-16 17:31:34 UTC) #1
Yang
On 2016/03/16 17:31:34, john.yan wrote: > S390: Add Printf format specifier lgtm.
4 years, 9 months ago (2016-03-17 08:09:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813453002/1
4 years, 9 months ago (2016-03-17 12:39:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 13:02:17 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 13:03:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da8b4fa7ed1e17910254cae7c3706c46f6fbc997
Cr-Commit-Position: refs/heads/master@{#34857}

Powered by Google App Engine
This is Rietveld 408576698