Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1813443003: Some fixes for Swarming bots (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 9 months ago
Reviewers:
kjlubick, borenet, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add some DLLs #

Patch Set 3 : glob the build products #

Patch Set 4 : Make win_toolchain.json writeable #

Patch Set 5 : Narrow down build products #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M infra/bots/common.py View 1 2 3 4 3 chunks +12 lines, -7 lines 0 comments Download
M infra/bots/flavor/default_flavor.py View 1 chunk +3 lines, -1 line 0 comments Download
M infra/bots/win_toolchain_utils.py View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
borenet
Patch set 3 ran successfully for me on a trial run. Still waiting on patch ...
4 years, 9 months ago (2016-03-17 15:40:38 UTC) #3
kjlubick
lgtm
4 years, 9 months ago (2016-03-17 15:41:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813443003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813443003/80001
4 years, 9 months ago (2016-03-17 15:42:55 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 15:58:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813443003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813443003/80001
4 years, 9 months ago (2016-03-17 16:00:25 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 16:01:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/64e9816429bfff0a666b5f0995e9124e2689595d

Powered by Google App Engine
This is Rietveld 408576698