Issue 181343003: Revert of Link chrome_elf.dll instead of statically linking the blacklist code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181343003: Revert of Link chrome_elf.dll instead of statically linking the blacklist code (Closed)

Created:
6 years, 10 months ago by ckocagil

Modified:
6 years, 10 months ago

Reviewers:
robertshield, csharp, sky

CC:
chromium-reviews, caitkp+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Revert of Link chrome_elf.dll instead of statically linking the blacklist code (https://codereview.chromium.org/176873012/) Reason for revert: Broke unit_tests on Win 7 debug: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=26698 Original issue's description: > Link chrome_elf.dll instead of statically linking the blacklist code > > This ensure that the dll code is referenced, instead of the target > making its own copy. > > > BUG=329023 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253366 TBR=robertshield@chromium.org,sky@chromium.org,csharp@chromium.org NOTREECHECKS=true NOTRY=true BUG=329023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253399

Created: 6 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome_elf/chrome_elf.def	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

ckocagil

Created Revert of Link chrome_elf.dll instead of statically linking the blacklist code

6 years, 10 months ago (2014-02-26 11:20:03 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/181343003/1

6 years, 10 months ago (2014-02-26 11:21:26 UTC) #2

Message was sent while issue was closed.

Change committed as 253399