third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable fast-path/slow-path comparison because of saturated operations of LayoutUnit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

index a60f188fd6f149177cde8c604ace7a8c7210d855..8a66fd86e1f36e3bb66ed7bc0f7f3f859141af66 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

@@ -516,11 +516,12 @@ void LayoutSVGText::invalidateTreeIfNeeded(const PaintInvalidationState& paintIn

if (reason == PaintInvalidationDelayedFull)

paintInvalidationState.pushDelayedPaintInvalidationTarget(*this);

+ // TODO(wangxianzhu): Move this to fast path if possible. crbug.com/391054.

ForceHorriblySlowRectMapping slowRectMapping(&newPaintInvalidationState);

if (reason == PaintInvalidationSVGResourceChange)

newPaintInvalidationState.setForceSubtreeInvalidationWithinContainer();

- newPaintInvalidationState.updatePaintOffsetAndClipForChildren();

+ newPaintInvalidationState.updateForChildren();

invalidatePaintOfSubtreesIfNeeded(newPaintInvalidationState);

}