third_party/WebKit/Source/core/layout/LayoutPart.cpp - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutPart.cpp

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable fast-path/slow-path comparison because of saturated operations of LayoutUnit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutPart.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutPart.cpp b/third_party/WebKit/Source/core/layout/LayoutPart.cpp

index 0a83a6843dfb5ec2ff752fc4fdbc5e235042c7b7..def0becaf8e64b131bac80de75d3016338fcc033 100644

--- a/third_party/WebKit/Source/core/layout/LayoutPart.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutPart.cpp

@@ -349,13 +349,13 @@ bool LayoutPart::setWidgetGeometry(const LayoutRect& frame)

void LayoutPart::invalidatePaintOfSubtreesIfNeeded(const PaintInvalidationState& paintInvalidationState)

{

- if (widget() && widget()->isFrameView()) {

+ if (widget() && widget()->isFrameView() && !isThrottledFrameView()) {

FrameView* childFrameView = toFrameView(widget());

// |childFrameView| is in another document, which could be

// missing its LayoutView. TODO(jchaffraix): Ideally we should

// not need this code.

if (LayoutView* childLayoutView = childFrameView->layoutView()) {

- PaintInvalidationState childViewPaintInvalidationState(*childLayoutView, paintInvalidationState);

+ PaintInvalidationState childViewPaintInvalidationState(paintInvalidationState, *childLayoutView);

childFrameView->invalidateTreeIfNeeded(childViewPaintInvalidationState);

}