third_party/WebKit/Source/core/layout/LayoutFlowThread.h - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable fast-path/slow-path comparison because of saturated operations of LayoutUnit Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

index bac6c8b347fe5421e726eef2d87bd51a9a7f0aa4..d9a34dde37274fda3717500a4c0df3c219be90ea 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.h

@@ -54,8 +54,6 @@ public:

virtual bool isLayoutMultiColumnFlowThread() const { return false; }

virtual bool isLayoutPagedFlowThread() const { return false; }

- bool supportsPaintInvalidationStateCachedOffsets() const override { return false; }

static LayoutFlowThread* locateFlowThreadContainingBlockOf(const LayoutObject&);

void layout() override;

@@ -82,7 +80,7 @@ public:

void invalidateColumnSets();

bool hasValidColumnSetInfo() const { return !m_columnSetsInvalidated && !m_multiColumnSetList.isEmpty(); }

- bool mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect&, const PaintInvalidationState*, VisibleRectFlags = DefaultVisibleRectFlags) const override;

+ bool mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect&, VisibleRectFlags = DefaultVisibleRectFlags) const override;

LayoutUnit pageLogicalHeightForOffset(LayoutUnit);

LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit, PageBoundaryRule);