third_party/WebKit/Source/core/layout/LayoutReplaced.h - Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutReplaced.h

Issue 1813383002: Move all fast-path paint invalidation mapping into PaintInvalidationState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutPart.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutReplaced.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutReplaced.h b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

index a3bfce444e6c1c6aca1ee30a8eeba09f98e8bfe5..35ac0c378ccc6f9add3cd4aa337f0290daf3ea50 100644

--- a/third_party/WebKit/Source/core/layout/LayoutReplaced.h

+++ b/third_party/WebKit/Source/core/layout/LayoutReplaced.h

@@ -66,7 +66,7 @@ public:

static const int defaultHeight;

bool canHaveChildren() const override { return false; }

virtual void paintReplaced(const PaintInfo&, const LayoutPoint&) const { }

- LayoutRect localSelectionRect() const; // This is in local coordinates, but it's a physical rect (so the top left corner is physical top left).

+ LayoutRect localSelectionRect() const final;

bool hasObjectFit() const { return style()->getObjectFit() != ComputedStyle::initialObjectFit(); }

@@ -123,7 +123,6 @@ private:

bool canBeSelectionLeaf() const override { return true; }

- LayoutRect selectionRectForPaintInvalidation(const LayoutBoxModelObject* paintInvalidationContainer) const final;

void computeIntrinsicSizingInfoForReplacedContent(LayoutReplaced*, IntrinsicSizingInfo&) const;

FloatSize constrainIntrinsicSizeToMinMax(const IntrinsicSizingInfo&) const;