Issue 18133010: Update metadata_dispatcher.js to check for SharedWorkerGlobalScope only

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18133010: Update metadata_dispatcher.js to check for SharedWorkerGlobalScope only (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org, lgombos

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update metadata_dispatcher.js to check for SharedWorkerGlobalScope only Update metadata_dispatcher.js to check for SharedWorkerGlobalScope only and stop checking for SharedWorkerContext now that Blink has rolled. WorkerContext was renamed to WorkerGlobalScope in order to match the latest specification in Blink r153030. R=arv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209332

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/resources/file_manager/js/metadata/metadata_dispatcher.js	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18133010/1

7 years, 5 months ago (2013-06-28 17:41:16 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=170888

7 years, 5 months ago (2013-06-28 23:43:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18133010/1

7 years, 5 months ago (2013-06-29 14:24:54 UTC) #5

Message was sent while issue was closed.

Change committed as 209332

Expand Messages | Collapse Messages