Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 18133003: Get rid of the extra vector when setting up the orderIterator. (Closed)

Created:
7 years, 5 months ago by ojan
Modified:
7 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

Get rid of the extra vector when setting up the orderIterator. -Rename computeMainAxisPreferredSizes. This name has been wrong for a long time. -Populate m_orderValues directly instead of first popuplating an on-stack vector and then copying the values into m_orderValues. -Avoid doing extra buffer allocations when resetting the m_orderValues entries. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -40 lines) Patch
M Source/core/rendering/RenderFlexibleBox.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 4 chunks +27 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ojan
7 years, 5 months ago (2013-06-27 20:45:49 UTC) #1
cbiesinger
lgtm
7 years, 5 months ago (2013-06-27 21:10:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/18133003/1
7 years, 5 months ago (2013-06-27 21:18:28 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-06-27 23:53:40 UTC) #4
Message was sent while issue was closed.
Change committed as 153185

Powered by Google App Engine
This is Rietveld 408576698