Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 181323005: Make HeapObjectHeader and FinalizedHeapObjectHeader visible in the shared object for newer GCC. (Closed)

Created:
6 years, 9 months ago by elecro
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make HeapObjectHeader and FinalizedHeapObjectHeader visible in the shared object for newer GCC. When building with newer GCC (4.8) and component=shared_library some classes are not visible in the created blink_heap shared object. R=ager@chromium.org BUG=349932 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168818

Patch Set 1 #

Patch Set 2 : Added windows fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/heap/Heap.h View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
elecro
6 years, 9 months ago (2014-03-06 16:20:26 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-06 22:03:33 UTC) #2
zerny-chromium
lgtm
6 years, 9 months ago (2014-03-07 06:39:19 UTC) #3
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-07 08:06:08 UTC) #4
elecro
The CQ bit was unchecked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-07 08:06:19 UTC) #5
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-07 08:06:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/181323005/1
6 years, 9 months ago (2014-03-07 08:06:22 UTC) #7
elecro
The CQ bit was unchecked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-07 08:07:15 UTC) #8
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-07 08:53:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/181323005/1
6 years, 9 months ago (2014-03-07 08:53:49 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 09:11:56 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile
6 years, 9 months ago (2014-03-07 09:11:57 UTC) #12
elecro
Updated the patchset, to try to fix the Windows build.
6 years, 9 months ago (2014-03-07 12:54:17 UTC) #13
haraken
LGTM
6 years, 9 months ago (2014-03-07 12:55:38 UTC) #14
elecro
The CQ bit was checked by pgal.u-szeged@partner.samsung.com
6 years, 9 months ago (2014-03-10 07:38:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgal.u-szeged@partner.samsung.com/181323005/20001
6 years, 9 months ago (2014-03-10 07:39:07 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 08:55:08 UTC) #17
Message was sent while issue was closed.
Change committed as 168818

Powered by Google App Engine
This is Rietveld 408576698