Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18132024: Add enhanced filters to Network panel. (Closed)

Created:
7 years, 5 months ago by eustas
Modified:
6 years, 9 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Add enhanced filters to Network panel. BUG=258421 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168371

Patch Set 1 #

Patch Set 2 : Update interface. #

Patch Set 3 : Moved suggestion list construction to helper class. #

Patch Set 4 : Rebased #

Patch Set 5 : Rebaseline #

Total comments: 4

Patch Set 6 : Addressed comments #

Total comments: 4

Patch Set 7 : UI tuning. Add more keys #

Patch Set 8 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -12 lines) Patch
M Source/devtools/front_end/NetworkPanel.js View 1 2 3 4 5 6 7 11 chunks +184 lines, -11 lines 0 comments Download
M Source/devtools/front_end/filter.css View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/networkPanel.css View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eustas
6 years, 11 months ago (2014-01-20 17:02:41 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/18132024/diff/27001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://chromiumcodereview.appspot.com/18132024/diff/27001/Source/devtools/front_end/NetworkPanel.js#newcode1606 Source/devtools/front_end/NetworkPanel.js:1606: DOMAIN: "domain", Domain https://chromiumcodereview.appspot.com/18132024/diff/27001/Source/devtools/front_end/NetworkPanel.js#newcode1607 Source/devtools/front_end/NetworkPanel.js:1607: MIME_TYPE: "mime-type" MimeType
6 years, 10 months ago (2014-02-20 07:36:38 UTC) #2
eustas
https://codereview.chromium.org/18132024/diff/27001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/18132024/diff/27001/Source/devtools/front_end/NetworkPanel.js#newcode1606 Source/devtools/front_end/NetworkPanel.js:1606: DOMAIN: "domain", On 2014/02/20 07:36:38, vsevik wrote: > Domain ...
6 years, 10 months ago (2014-02-21 15:27:45 UTC) #3
vsevik
lgtm https://codereview.chromium.org/18132024/diff/187001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/18132024/diff/187001/Source/devtools/front_end/NetworkPanel.js#newcode1362 Source/devtools/front_end/NetworkPanel.js:1362: throw "Unknown filter type:" + type; console.assert(false, "...") ...
6 years, 10 months ago (2014-02-25 06:58:52 UTC) #4
eustas
https://codereview.chromium.org/18132024/diff/187001/Source/devtools/front_end/NetworkPanel.js File Source/devtools/front_end/NetworkPanel.js (right): https://codereview.chromium.org/18132024/diff/187001/Source/devtools/front_end/NetworkPanel.js#newcode1362 Source/devtools/front_end/NetworkPanel.js:1362: throw "Unknown filter type:" + type; On 2014/02/25 06:58:53, ...
6 years, 9 months ago (2014-02-28 09:16:53 UTC) #5
eustas
Finished =) PTAL
6 years, 9 months ago (2014-02-28 09:18:41 UTC) #6
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-03 15:27:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/18132024/247001
6 years, 9 months ago (2014-03-03 15:27:37 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 20:02:00 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=24782
6 years, 9 months ago (2014-03-03 20:02:01 UTC) #10
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 9 months ago (2014-03-04 08:22:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/18132024/247001
6 years, 9 months ago (2014-03-04 08:23:17 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 08:25:48 UTC) #13
Message was sent while issue was closed. 
Change committed as 168371

Powered by Google App Engine
This is Rietveld 408576698