Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 18132009: move failable work outside of constructors for SkGlyphCache and SkScalerContextGDI. If we fail, try… (Closed)

Created:
7 years, 5 months ago by reed1
Modified:
7 years, 5 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

move failable work outside of constructors for SkGlyphCache and SkScalerContextGDI. If we fail, try to purge everything and try again, in case the failure was from memory/os-resource exhaustion (e.g. out of HDC handles in windows) BUG= Committed: https://code.google.com/p/skia/source/detail?r=9930

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M src/core/SkGlyphCache.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/core/SkGlyphCache.cpp View 1 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
reed1
7 years, 5 months ago (2013-07-08 19:10:59 UTC) #1
bungeman-skia
It seems like what is wanted is for every time one tries to obtain an ...
7 years, 5 months ago (2013-07-08 19:36:49 UTC) #2
reed1
On 2013/07/08 19:36:49, bungeman1 wrote: > It seems like what is wanted is for every ...
7 years, 5 months ago (2013-07-09 12:55:37 UTC) #3
reed1
removed win specific aspects
7 years, 5 months ago (2013-07-09 14:12:14 UTC) #4
reed1
7 years, 5 months ago (2013-07-09 15:29:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r9930 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698