Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: chrome/browser/sync/glue/data_type_manager_impl.h

Issue 18132003: [Sync] Trigger unapply + getupdates for persistence errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Self review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_manager_impl.h
diff --git a/chrome/browser/sync/glue/data_type_manager_impl.h b/chrome/browser/sync/glue/data_type_manager_impl.h
index c2fb91bc25df6122dd656e84b30a08dd0a1b3d2b..a3534db0804bcaf1be46ccde6ab72770ecba39d9 100644
--- a/chrome/browser/sync/glue/data_type_manager_impl.h
+++ b/chrome/browser/sync/glue/data_type_manager_impl.h
@@ -73,22 +73,27 @@ class DataTypeManagerImpl : public DataTypeManager,
return &model_association_manager_;
}
- protected:
- // Divide |types| into sets by their priorities and return the sets from
- // high priority to low priority.
- virtual TypeSetPriorityList PrioritizeTypes(
- const syncer::ModelTypeSet& types);
-
private:
+ friend class TestDataTypeManager;
+
// Abort configuration and stop all data types due to configuration errors.
void Abort(ConfigureStatus status,
const syncer::SyncError& error);
+ // Returns the priority types (control + priority user types).
+ // Virtual for overriding during tests.
+ virtual syncer::ModelTypeSet GetPriorityTypes() const;
+
+ // Divide |types| into sets by their priorities and return the sets from
+ // high priority to low priority.
+ TypeSetPriorityList PrioritizeTypes(const syncer::ModelTypeSet& types);
+
// Post a task to reconfigure when no downloading or association are running.
void ProcessReconfigure();
void Restart(syncer::ConfigureReason reason);
void DownloadReady(base::Time download_start_time,
+ syncer::ModelTypeSet types_to_download,
syncer::ModelTypeSet high_priority_types_before,
syncer::ModelTypeSet first_sync_types,
syncer::ModelTypeSet failed_configuration_types);

Powered by Google App Engine
This is Rietveld 408576698