Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1813073002: Temporarily disable IOSurface 2D Canvas to debug a trace_test failure. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, danakj+watch_chromium.org, Rik, f(malita), blink-reviews, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable IOSurface 2D Canvas to debug a trace_test failure. The first time IOSurface 2D Canvas was enabled, there were no test failures over several days. The second time it was enabled (along with a bug fix, and some new tests), trace_test.IOSurface2DCanvas started flakily failing. BUG=595754 Committed: https://crrev.com/f4f91cf0abc666aa189c2ee666b7acf0361d00bf Cr-Commit-Position: refs/heads/master@{#381843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
erikchen
kbr: Please review.
4 years, 9 months ago (2016-03-17 22:37:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813073002/1
4 years, 9 months ago (2016-03-17 22:37:43 UTC) #4
Justin Novosad
lgtm
4 years, 9 months ago (2016-03-17 22:49:58 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 00:06:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813073002/1
4 years, 9 months ago (2016-03-18 00:08:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 00:14:16 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:16:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4f91cf0abc666aa189c2ee666b7acf0361d00bf
Cr-Commit-Position: refs/heads/master@{#381843}

Powered by Google App Engine
This is Rietveld 408576698