Fix DrMemory warning in VS 2015 CRT

Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500, 594808
Committed: https://crrev.com/4ecae6cf0186d351706937b23d00ccaa5db9f1be
Cr-Commit-Position: refs/heads/master@{#381840}

[brucedawson, 2016-03-17 21:29:01]

brucedawson@chromium.org changed reviewers:
+ oshima@chromium.org

[brucedawson, 2016-03-17 21:29:02]

PTAL

[brucedawson, 2016-03-17 21:31:07]

Description was changed from

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808
==========

to

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808
==========

[oshima, 2016-03-17 22:02:20]

can you move it to "wrong analysis" section at the top of the file (or no
control section)? then lgtm

[brucedawson, 2016-03-17 23:14:44]

On 2016/03/17 22:02:20, oshima wrote:
> can you move it to "wrong analysis" section at the top of the file (or no
> control section)? then lgtm

Ah - that makes sense. Done.

[brucedawson, 2016-03-17 23:21:33]

The CQ bit was checked by brucedawson@chromium.org

[brucedawson, 2016-03-17 23:21:33]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1813063002/#ps20001
(title: "Move suppression")

[commit-bot: I haz the power, 2016-03-17 23:22:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1813063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1813063002/20001

[commit-bot: I haz the power, 2016-03-17 23:56:53]

Description was changed from

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808
==========

to

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808
==========

[commit-bot: I haz the power, 2016-03-17 23:56:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-17 23:58:07]

Description was changed from

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808
==========

to

==========
Fix DrMemory warning in VS 2015 CRT

In VS 2015 builds every call to realloc triggers a warning like this:

Error #1: INVALID HEAP ARGUMENT: allocated with Windows API layer, queried with
C library layer
  0 replace_malloc_usable_size
  1 _recalloc_base
  2 <lambda_4e60a939b0d047cfe11ddc22648dfba9>::operator()
  3 __crt_seh_guarded_call<>::operator()<>
  4 __acrt_lock_and_call<>
  5 _register_onexit_function
  6 _crt_atexit
  7 _onexit
  8 atexit
  9 testing::`dynamic initializer for 'FLAGS_gmock_verbose''

This mismatch is harmless (because the CRT always uses the Windows heap)
and out of our control. Therefore it should be suppressed.

With this suppression I now get a clean run on this previously failing
test:

tools\valgrind\chrome_tests.bat -t content_browsertests --tool \
    drmemory_light --build-dir=out\Release \
    --gtest_filter=ManifestBrowserTest.DummyManifest

BUG=440500,594808

Committed: https://crrev.com/4ecae6cf0186d351706937b23d00ccaa5db9f1be
Cr-Commit-Position: refs/heads/master@{#381840}
==========

[commit-bot: I haz the power, 2016-03-17 23:58:08]

Patchset 2 (id:??) landed as
https://crrev.com/4ecae6cf0186d351706937b23d00ccaa5db9f1be
Cr-Commit-Position: refs/heads/master@{#381840}

[Derek Bruening, 2016-03-20 02:36:24]

I cannot reproduce the heap mismatch on ManifestBrowserTest.*.  Additionally,
this suppression has never been hit on the bots:

http://chromium-build-logs.appspot.com/suppression_query?suppression_query=re...

We would prefer to address this kind of issue that affects more than just Cr
with a Dr. Memory fix and not a Cr suppression.  Without any repro, though,
after the other VS2015 fixes are in, the right step may be to remove this
suppression and confirm that this does not show up on the bots.

[Derek Bruening, 2016-03-20 04:03:01]

From the CL description up top:
> This mismatch is harmless (because the CRT always uses the Windows heap)
> and out of our control. Therefore it should be suppressed.

This is inaccurate.  Prior to VS2012, the CRT used a private heap, and only with
VS2012+ does it use the default process heap.  However, the debug CRT adds its
own redzone around the allocation returned by the Rtl layer, meaning that you
cannot mix heap alloc pointers between the two layers.  Thus, in general it is a
bug to allocate with one and free with the other, with real consequences such as
crashes.