Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1813053005: Fix to ensure the product mode builds again. (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : self-review-comments #

Total comments: 2

Patch Set 3 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M runtime/vm/compiler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/gc_marker.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/gc_sweeper.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/heap.cc View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/timeline.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 9 months ago (2016-03-18 21:14:37 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1813053005/diff/20001/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/1813053005/diff/20001/runtime/vm/timeline.h#newcode395 runtime/vm/timeline.h:395: #define TIMELINE_FUNCTION_GC_DURATION(thread, name) Switch the collectnew/collectold events to ...
4 years, 9 months ago (2016-03-18 21:18:02 UTC) #3
siva
https://codereview.chromium.org/1813053005/diff/20001/runtime/vm/timeline.h File runtime/vm/timeline.h (right): https://codereview.chromium.org/1813053005/diff/20001/runtime/vm/timeline.h#newcode395 runtime/vm/timeline.h:395: #define TIMELINE_FUNCTION_GC_DURATION(thread, name) On 2016/03/18 21:18:02, rmacnak wrote: > ...
4 years, 9 months ago (2016-03-18 21:23:06 UTC) #4
siva
4 years, 9 months ago (2016-03-18 21:27:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
bb62e8c70276ad6d75dcbe70acd61ccaed1ca189 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698