third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1813053004: Move grid-auto-column/grid-auto-row into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1813053004: Move grid-auto-column/grid-auto-row into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up a bit more Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index 7abc6ca2466d2b60e9700b1ae8e891f6280c2e9c..46dfcf07797b90f1060664a9ffb7f1fa063a2ccb 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -43,6 +43,8 @@ class CSSValue;

class CSSValueList;

class StylePropertyShorthand;

+enum TrackSizeRestriction { FixedSizeOnly, AllowAll };

Timothy Loh 2016/03/22 06:33:59 TODO to move to cpp file once legacy parser is rem

rwlbuis 2016/03/22 20:48:12 Done.

// Inputs: PropertyID, isImportant bool, CSSParserValueList.

// Outputs: Vector of CSSProperties

@@ -112,7 +114,6 @@ private:

bool consumeColumns(bool important);

- enum TrackSizeRestriction { FixedSizeOnly, AllowAll };

bool consumeGridItemPositionShorthand(CSSPropertyID, bool important);

PassRefPtrWillBeRawPtr<CSSValue> parseGridTemplateColumns(bool important);

bool parseGridTemplateRowsAndAreasAndColumns(bool important);