Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1813043002: Move the hiding of Views location bar bubbles into LocationBarView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move bubble hiding into LocationBarView Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 9d7584a4eec119082d63e9642b50a64fac263312..89a07fb10f85b7f2d917dc4b3eb81345e5e102e4 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -95,7 +95,6 @@
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "chrome/browser/ui/views/translate/translate_bubble_view.h"
#include "chrome/browser/ui/views/update_recommended_message_box.h"
-#include "chrome/browser/ui/views/website_settings/permissions_bubble_view.h"
#include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
#include "chrome/browser/ui/website_settings/permission_bubble_manager.h"
#include "chrome/browser/ui/window_sizer/window_sizer.h"
@@ -889,14 +888,6 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,
infobar_container_->ChangeInfoBarManager(
InfoBarService::FromWebContents(new_contents));
- if (old_contents && PermissionBubbleManager::FromWebContents(old_contents))
- PermissionBubbleManager::FromWebContents(old_contents)->HideBubble();
-
- if (new_contents && PermissionBubbleManager::FromWebContents(new_contents)) {
- PermissionBubbleManager::FromWebContents(new_contents)
- ->DisplayPendingRequests();
- }
-
UpdateUIForContents(new_contents);
// Layout for DevTools _before_ setting the both main and devtools WebContents
@@ -920,9 +911,6 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents,
// Update all the UI bits.
UpdateTitleBar();
-
- TranslateBubbleView::CloseCurrentBubble();
- ZoomBubbleView::CloseCurrentBubble();
}
void BrowserView::ZoomChangedForActiveTab(bool can_show_bubble) {
@@ -1599,9 +1587,6 @@ void BrowserView::TabInsertedAt(WebContents* contents,
}
void BrowserView::TabDetachedAt(WebContents* contents, int index) {
- if (PermissionBubbleManager::FromWebContents(contents))
- PermissionBubbleManager::FromWebContents(contents)->HideBubble();
-
// We use index here rather than comparing |contents| because by this time
// the model has already removed |contents| from its list, so
// browser_->GetActiveWebContents() will return null or something else.
@@ -1617,9 +1602,6 @@ void BrowserView::TabDetachedAt(WebContents* contents, int index) {
}
void BrowserView::TabDeactivated(WebContents* contents) {
- if (PermissionBubbleManager::FromWebContents(contents))
- PermissionBubbleManager::FromWebContents(contents)->HideBubble();
-
// We do not store the focus when closing the tab to work-around bug 4633.
// Some reports seem to show that the focus manager and/or focused view can
// be garbage at that point, it is not clear why.
« no previous file with comments | « chrome/browser/ui/views/autofill/save_card_icon_view.cc ('k') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698