Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.h

Issue 1813023002: Add a notice about other forms of history to the CBD dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_component
Patch Set: Update strings. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.h
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.h b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
index 44786bc08803c30c982073f3abe189e3eab6f95b..036cb164b6bd2df37550b710c66cdbf205ebb153 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.h
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
@@ -58,6 +58,18 @@ class ClearBrowserDataHandler : public OptionsPageUIHandler,
// bottom of the dialog.
void OnStateChanged() override;
+ // Finds out whether we should show a notice informing the user about other
+ // forms of browsing history. Responds with an asynchronous callback to
+ // |UpdateHistoryNotice|.
+ void RefreshHistoryNotice();
+
+ // Shows or hides the notice about other forms of browsing history.
+ void UpdateHistoryNotice(bool show);
+
+ // Remembers whether we should popup a dialog about other forms of browsing
+ // history when the user deletes the history for the first time.
+ void UpdateHistoryDeletionDialog(bool show);
+
// If non-null it means removal is in progress.
BrowsingDataRemover* remover_;
@@ -77,6 +89,16 @@ class ClearBrowserDataHandler : public OptionsPageUIHandler,
// Informs us whether the user is syncing their data.
ProfileSyncService* sync_service_;
+ // Whether we should show a notice about other forms of browsing history.
+ bool should_show_history_notice_;
+
+ // Whether we should popup a dialog about other forms of browsing history
+ // when the user deletes their browsing history for the first time.
+ bool should_show_history_deletion_dialog_;
+
+ // A weak pointer factory for asynchronous calls referencing this class.
+ base::WeakPtrFactory<ClearBrowserDataHandler> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(ClearBrowserDataHandler);
};
« no previous file with comments | « chrome/browser/ui/browser_ui_prefs.cc ('k') | chrome/browser/ui/webui/options/clear_browser_data_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698