Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.css

Issue 1813023002: Add a notice about other forms of history to the CBD dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_component
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.css
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.css b/chrome/browser/resources/options/clear_browser_data_overlay.css
index fca5b8d57f8a02f551fd14dafcb920f0ebacf7f2..f5ee4daef800dfeb618f4306b563743e7731312b 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.css
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.css
@@ -48,10 +48,34 @@ input[type=checkbox]:not(:checked) ~ .clear-browser-data-counter {
display: none;
}
+#some-stuff-remains-footer {
+ display: block;
+}
+
#some-stuff-remains-footer > p {
- margin: 0;
+ padding-left: 33px;
Dan Beam 2016/03/18 22:48:39 you should try this UI in RTL (you probably need -
msramek 2016/03/21 16:30:25 Thanks for the sanity check, I forgot about that.
}
#some-stuff-remains-footer button {
padding: 0;
}
+
+#clear-browser-data-history-footer {
+ background-image: url(googleg.svg);
+ background-position: left center;
Dan Beam 2016/03/18 22:48:39 this also needs to be mirrored in RTL, i.e. html[
msramek 2016/03/21 16:30:25 Done.
+ background-repeat: no-repeat;
+ background-size: 16px 16px;
+ margin: 0 0 0.8em 0;
Dan Beam 2016/03/18 22:48:39 is this intentionally zeroing top/left/right margi
msramek 2016/03/21 16:30:25 It is intentional, same as "margin: 0" in #clear-b
+}
+
+#clear-browser-data-general-footer {
+ background-image: url(info.svg);
+ background-position: left center;
+ background-repeat: no-repeat;
+ background-size: 18px 18px;
+ margin: 0;
+}
+
+#clear-browser-data-history-notice {
+ width: 300px;
+}

Powered by Google App Engine
This is Rietveld 408576698