chrome/browser/resources/options/clear_browser_data_overlay.css - Issue 1813023002: Add a notice about other forms of history to the CBD dialog

Side by Side Diff: chrome/browser/resources/options/clear_browser_data_overlay.css

Issue 1813023002: Add a notice about other forms of history to the CBD dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_component

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/options/clear_browser_data_history_notice_overlay.js ('K') | « chrome/browser/resources/options/clear_browser_data_history_notice_overlay.js ('k') | chrome/browser/resources/options/clear_browser_data_overlay.html » ('j') | chrome/browser/resources/options/info.svg » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 #clear-browser-data-overlay {	5 #clear-browser-data-overlay {

6 width: 500px;	6 width: 500px;

7 }	7 }

8	8

9 #clear-data-checkboxes {	9 #clear-data-checkboxes {

10 -webkit-padding-start: 8px;	10 -webkit-padding-start: 8px;

(...skipping 30 matching lines...) Expand all Loading...
41 }	41 }

42	42

43 input[type=checkbox]:not(:checked) ~ .clear-browser-data-counter {	43 input[type=checkbox]:not(:checked) ~ .clear-browser-data-counter {

44 display: none;	44 display: none;

45 }	45 }

46	46

47 #clear-browser-data-info-banner:empty {	47 #clear-browser-data-info-banner:empty {

48 display: none;	48 display: none;

49 }	49 }

50	50

	51 #some-stuff-remains-footer {

	52 display: block;

	53 }

	54

51 #some-stuff-remains-footer > p {	55 #some-stuff-remains-footer > p {

52 margin: 0;	56 padding-left: 33px;
	Dan Beam 2016/03/18 22:48:39 you should try this UI in RTL (you probably need - you should try this UI in RTL (you probably need -webkit-padding-start: 33px instead) msramek 2016/03/21 16:30:25 Thanks for the sanity check, I forgot about that. Show quoted text On 2016/03/18 22:48:39, Dan Beam wrote: > you should try this UI in RTL (you probably need -webkit-padding-start: 33px > instead) Thanks for the sanity check, I forgot about that. It's still not clear to me how to convince my Linux Chromium to use a different display language, but I used <html dir="rtl"> and style: {direction: 'rtl'} to approximate it. The two suggestions you made mirror the footer correctly.
53 }	57 }

54	58

55 #some-stuff-remains-footer button {	59 #some-stuff-remains-footer button {

56 padding: 0;	60 padding: 0;

57 }	61 }

	62

	63 #clear-browser-data-history-footer {

	64 background-image: url(googleg.svg);

	65 background-position: left center;
	Dan Beam 2016/03/18 22:48:39 this also needs to be mirrored in RTL, i.e. html[ this also needs to be mirrored in RTL, i.e. html[dir='rtl'] #clear-browser-data-history-footer, html[dir='rtl'] #clear-browser-data-general-footer { background-position: right center; } msramek 2016/03/21 16:30:25 Done. Show quoted text On 2016/03/18 22:48:39, Dan Beam wrote: > this also needs to be mirrored in RTL, i.e. > > html[dir='rtl'] #clear-browser-data-history-footer, > html[dir='rtl'] #clear-browser-data-general-footer { > background-position: right center; > } Done.
	66 background-repeat: no-repeat;

	67 background-size: 16px 16px;

	68 margin: 0 0 0.8em 0;
	Dan Beam 2016/03/18 22:48:39 is this intentionally zeroing top/left/right margi is this intentionally zeroing top/left/right margins or could this just be margin-buttom: 0.8em? msramek 2016/03/21 16:30:25 It is intentional, same as "margin: 0" in #clear-b Show quoted text On 2016/03/18 22:48:39, Dan Beam wrote: > is this intentionally zeroing top/left/right margins or could this just be > margin-buttom: 0.8em? It is intentional, same as "margin: 0" in #clear-browser-data-general-footer below. Just that in this case, we also want a bit of spacing between the two paragraphs.
	69 }

	70

	71 #clear-browser-data-general-footer {

	72 background-image: url(info.svg);

	73 background-position: left center;

	74 background-repeat: no-repeat;

	75 background-size: 18px 18px;

	76 margin: 0;

	77 }

	78

	79 #clear-browser-data-history-notice {

	80 width: 300px;

	81 }

OLD	NEW