chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html - Issue 1813023002: Add a notice about other forms of history to the CBD dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/clear_browser_data_history_notice_overlay.html

Issue 1813023002: Add a notice about other forms of history to the CBD dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_component

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/resources/options/clear_browser_data_history_notice_overlay.js » ('j') | chrome/browser/resources/options/clear_browser_data_history_notice_overlay.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <div id="clear-browser-data-history-notice" class="page" hidden>

	2 <h1 i18n-content="clearBrowserDataHistoryNoticeTitle"></h1>

	3 <div class="content-area">

	4 <p i18n-values=".innerHTML:clearBrowserDataHistoryNotice"></p>

	5 </div>

	6 <div class="action-area">

	7 <div class="button-strip">

	8 <button id="clear-browser-data-history-notice-ok" class="default-button"

	9 i18n-content="ok" onclick="PageManager.closeOverlay();">
	Dan Beam 2016/03/18 22:48:39 don't use on= attributes in HTML, put this in a s don't use on= attributes in HTML, put this in a separate .js instead (which is looks like you already have?) msramek 2016/03/21 16:30:24 Sorry, this is just a forgotten testing code. Yes, Show quoted text On 2016/03/18 22:48:39, Dan Beam wrote: > don't use on*= attributes in HTML, put this in a separate .js instead (which is > looks like you already have?) Sorry, this is just a forgotten testing code. Yes, it's already in the JS file.
	10 </button>

	11 </div>

	12 </div>

	13 </div>

OLD	NEW