Issue 18130006: Remove WebTestProxy override of WebFrameClient::createMediaPlayer().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18130006: Remove WebTestProxy override of WebFrameClient::createMediaPlayer(). (Closed)

Created:
7 years, 5 months ago by scherkus (not reviewing)

Modified:
7 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, jochen+watch_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove WebTestProxy override of WebFrameClient::createMediaPlayer(). While migrating webkit/renderer/media/ to content/renderer/media/ it became apparent that overriding media player creation for layout tests violates the content API. Instead a smaller public content API is exposed for test purposes. BUG=239826 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153472

Patch Set 1 #

Patch Set 2 : rebase #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
M	Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/testing/WebTestDelegate.h	View	1	2 chunks	+0 lines, -5 lines	0 comments	Download
M	public/testing/WebTestProxy.h	View	1	3 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

jochen can you take a look? FYI: this can't roll into Chromium until https://codereview.chromium.org/18123002/ lands

7 years, 5 months ago (2013-06-28 05:41:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18130006/4001

7 years, 5 months ago (2013-07-02 23:33:21 UTC) #3

Message was sent while issue was closed.

Change committed as 153472

Expand Messages | Collapse Messages