runtime/vm/flow_graph_compiler_mips.cc - Issue 18130004: Split IdenticalWithNumberCheck in two versions: once called from unoptimized code the other called…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 18130004: Split IdenticalWithNumberCheck in two versions: once called from unoptimized code the other called… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_mips.cc

===================================================================

--- runtime/vm/flow_graph_compiler_mips.cc (revision 24547)

+++ runtime/vm/flow_graph_compiler_mips.cc (working copy)

@@ -1399,7 +1399,11 @@

__ sw(reg, Address(SP, 1 * kWordSize));

__ LoadObject(TMP1, obj);

__ sw(TMP1, Address(SP, 0 * kWordSize));

- __ BranchLink(&StubCode::IdenticalWithNumberCheckLabel());

+ if (is_optimizing()) {

+ __ BranchLink(&StubCode::OptimizedIdenticalWithNumberCheckLabel());

+ } else {

+ __ BranchLink(&StubCode::UnoptimizedIdenticalWithNumberCheckLabel());

+ }

AddCurrentDescriptor(PcDescriptors::kRuntimeCall,

Isolate::kNoDeoptId,

token_pos);

@@ -1422,7 +1426,11 @@

__ addiu(SP, SP, Immediate(-2 * kWordSize));

__ sw(left, Address(SP, 1 * kWordSize));

__ sw(right, Address(SP, 0 * kWordSize));