fix build issue on Linux with GCC 4.1.2...

fix build issue on Linux with GCC 4.1.2
related to non-virtual destructors in classes having virtual methods

BUG=1859

[please use my chromium address, 2008-09-08 16:03:24]

After this it compiles fine, and unit tests pass.

I only tested this on Linux, don't know whether it breaks build on Windows.

[cedric.venet_ecp.fr, 2008-09-08 16:27:05]

a small error in the description:

related to non-virtual constructors in classes having virtual methods
                       ^^^^^^^^^^^^
should be destructors (virtual constructor isn't C++ :))

[please use my chromium address, 2008-09-08 16:36:07]

On 2008/09/08 16:27:05, cedric.venet wrote:
> should be destructors (virtual constructor isn't C++ :))

Thanks for noticing my stupid thinko. Corrected.

[Evan Martin, 2008-09-08 17:56:19]

I think these virtual destructors need to either be pure-virtual or to have
bodies or you'll get linker errors.

http://codereview.chromium.org/1813/diff/1/4
File webkit/glue/webplugin.h (right):

http://codereview.chromium.org/1813/diff/1/4#newcode145
Line 145: virtual ~WebPluginResourceClient();
Can you put this at the top? (Just under "public:")

[please use my chromium address, 2008-09-08 19:46:05]

On 2008/09/08 17:56:19, Evan Martin wrote:
> I think these virtual destructors need to either be pure-virtual or to have
> bodies or you'll get linker errors.

Oh, fixed that (added bodies).

> Line 145: virtual ~WebPluginResourceClient();
> Can you put this at the top? (Just under "public:")

Done.

[Evan Martin, 2008-09-08 20:18:56]

Have you done the CLA (http://dev.chromium.org/developers/contributing-code) ?

If you put your name in the authors file I'll credit you in the commit.

[please use my chromium address, 2008-09-08 20:28:09]

On 2008/09/08 20:18:56, Evan Martin wrote:
> Have you done the CLA (http://dev.chromium.org/developers/contributing-code) ?

Yes, via electronic form submission.

> If you put your name in the authors file I'll credit you in the commit.

Done, thank you.

[Evan Martin, 2008-09-08 20:57:28]

Committed as r1860.

[Evan Martin, 2008-09-09 19:24:50]

Would you mind closing this issue?
Go do "Edit issue" on the left, pick the "closed" checkbox, and save.