third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h - Issue 1812983002: [DevTools] Move evaluate from InjectedScriptSource.js to native

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

Issue 1812983002: [DevTools] Move evaluate from InjectedScriptSource.js to native (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move-evaluate-on-call-frame

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/console/console-control-characters-expected.txt ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

index 5bf8dc431c6ef8083e00943fbeb4f8d557e27e9c..9b808efc0b223c6fa4fa33fca8d4c12ab8b93da7 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptManager.h

@@ -55,7 +55,7 @@ public:

V8DebuggerImpl* debugger() { return m_debugger; }

InjectedScript* injectedScriptFor(v8::Local<v8::Context>);

- InjectedScript* findInjectedScript(int) const;

+ InjectedScript* findInjectedScript(ErrorString*, int) const;

InjectedScript* findInjectedScript(ErrorString*, RemoteObjectIdBase*) const;

void discardInjectedScripts();

int discardInjectedScriptFor(v8::Local<v8::Context>);