Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1812963002: Use sktarray.begin() instead of &sktarray[0]. (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use sktarray.begin() instead of &sktarray[0]. Evaluating &sktarray[0] when sktarray.count() == 0 asserts. This was causing ASAN failures. TBR=bsalomon NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/c85ce7ce805135d34b11067c502a5f88506cce44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/gpu/gl/GrGLPath.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812963002/1
4 years, 9 months ago (2016-03-17 17:12:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812963002/1
4 years, 9 months ago (2016-03-17 17:14:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812963002/1
4 years, 9 months ago (2016-03-17 17:21:13 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:22:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c85ce7ce805135d34b11067c502a5f88506cce44

Powered by Google App Engine
This is Rietveld 408576698