chrome/browser/resources/options/search_engine_manager_engine_list.js - Issue 181293005: Show the full extension information in the extension controlled setting bubble

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/search_engine_manager_engine_list.js

Issue 181293005: Show the full extension information in the extension controlled setting bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix z-order glitch Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/search_engine_manager_engine_list.js

diff --git a/chrome/browser/resources/options/search_engine_manager_engine_list.js b/chrome/browser/resources/options/search_engine_manager_engine_list.js

index 9bc12b9f8b618b9647d0357e07d7dbc3440c71f0..450d6fd2517f27a3edaf4ae161e7ec9223909528 100644

--- a/chrome/browser/resources/options/search_engine_manager_engine_list.js

+++ b/chrome/browser/resources/options/search_engine_manager_engine_list.js

@@ -186,9 +186,8 @@ cr.define('options.search_engines', function() {

// CoreOptionsHandler::CreateValueForPref() does.

var event = new Event(this.contentType);

if (engine.extension) {

- event.value = { controlledBy: 'extension' };

- // TODO(mad): add id, name, and icon once we solved the issue with the

- // search engine manager in http://crbug.com/314507.

+ event.value = { controlledBy: 'extension',

+ extension: engine.extension};

Dan Beam 2014/03/07 20:13:02 nit: space before } to stay consistent with other

} else {

event.value = { controlledBy: 'policy' };

}

« no previous file with comments | « chrome/browser/resources/options/search_engine_manager.css ('k') | no next file » | no next file with comments »