Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1584)

Issue 1812923003: Add an explicit distinction between a command's description and summary. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/args@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add an explicit distinction between a command's description and summary. ff4dd9a8e2255f998fd2f017205d9f908f82b8de broke some users who were relying on only the first line of a command's description being included in its runner's usage as a summary. That is once again the default behavior. To support the use case described in #42, there's a new Command.summary getter that explicitly controls the summary included in the parent runner's usage. This defaults to the first line of the description, but may be overridden to declare a multi-line summary. Closes #42 R=rnystrom@google.com Committed: https://github.com/dart-lang/args/commit/0160fae46e40562acafd15c793d59a38575568a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M CHANGELOG.md View 1 chunk +11 lines, -0 lines 0 comments Download
M lib/command_runner.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/command_runner_test.dart View 2 chunks +19 lines, -1 line 0 comments Download
M test/utils.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-03-17 20:06:22 UTC) #1
Bob Nystrom
lgtm
4 years, 4 months ago (2016-03-17 22:47:19 UTC) #2
nweiz
4 years, 4 months ago (2016-03-17 22:53:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0160fae46e40562acafd15c793d59a38575568a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698