Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 18129003: Fix infinite loop in regress-opt-after-deopt. (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix infinite loop in regress-opt-after-deopt. %CompleteOptimization attempts to install optimized functions that the parallel thread has put on the output queue, as long as the function is marked with a builtin. However, activating the debugger will set all functions to the lazy recompile builtin, without the function being on the parallel recompilation pipeline. So we wait for the function to finish parallel recompilation while it's marked by a builtin that's unrelated to parallel recompilation. R=hpayer@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15404

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/runtime.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 5 months ago (2013-07-01 08:45:13 UTC) #1
Hannes Payer (out of office)
LGTM! Can we update the comment above the while loop with the description you gave ...
7 years, 5 months ago (2013-07-01 08:54:25 UTC) #2
Yang
7 years, 5 months ago (2013-07-01 09:14:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15404 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698