content/browser/renderer_host/render_view_host_unittest.cc - Issue 18129002: Update the child process security policy to use explicit permission grants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_unittest.cc

Issue 18129002: Update the child process security policy to use explicit permission grants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase to head Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.cc ('K') | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/public/browser/child_process_security_policy.h » ('j') | content/public/browser/child_process_security_policy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_unittest.cc

diff --git a/content/browser/renderer_host/render_view_host_unittest.cc b/content/browser/renderer_host/render_view_host_unittest.cc

index dca3da8205e97345b1a0efe2b7239c3457f70ab0..5661316987f3c0ba3b3639019715bd318e7c11c1 100644

--- a/content/browser/renderer_host/render_view_host_unittest.cc

+++ b/content/browser/renderer_host/render_view_host_unittest.cc

@@ -267,12 +267,8 @@ TEST_F(RenderViewHostTest, MessageWithBadHistoryItemFiles) {

test_rvh()->TestOnUpdateStateWithFile(process()->GetID(), file_path);

EXPECT_EQ(1, process()->bad_msg_count());

- ChildProcessSecurityPolicyImpl::GetInstance()->GrantPermissionsForFile(

- process()->GetID(), file_path,

- base::PLATFORM_FILE_OPEN |

- base::PLATFORM_FILE_READ |

- base::PLATFORM_FILE_EXCLUSIVE_READ |

- base::PLATFORM_FILE_ASYNC);

+ ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadFile(

+ process()->GetID(), file_path);

test_rvh()->TestOnUpdateStateWithFile(process()->GetID(), file_path);

EXPECT_EQ(1, process()->bad_msg_count());

}

@@ -286,12 +282,8 @@ TEST_F(RenderViewHostTest, NavigationWithBadHistoryItemFiles) {

test_rvh()->SendNavigateWithFile(1, url, file_path);

EXPECT_EQ(1, process()->bad_msg_count());

- ChildProcessSecurityPolicyImpl::GetInstance()->GrantPermissionsForFile(

- process()->GetID(), file_path,

- base::PLATFORM_FILE_OPEN |

- base::PLATFORM_FILE_READ |

- base::PLATFORM_FILE_EXCLUSIVE_READ |

- base::PLATFORM_FILE_ASYNC);

+ ChildProcessSecurityPolicyImpl::GetInstance()->GrantReadFile(

+ process()->GetID(), file_path);

test_rvh()->SendNavigateWithFile(process()->GetID(), url, file_path);

EXPECT_EQ(1, process()->bad_msg_count());

}