chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc - Issue 18129002: Update the child process security policy to use explicit permission grants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

Issue 18129002: Update the child process security policy to use explicit permission grants. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc » ('j') | chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc b/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

index cfe538bee9ec841b580c205ecb36cc4f6d82b1a2..b73b25b9380f0fbc07c8438d4e5fcb268f46830c 100644

--- a/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc

@@ -381,10 +381,8 @@ void FileBrowserHandlerInternalSelectFileFunction::GrantPermissions() {

external_provider->GrantFileAccessToExtension(extension_id(), virtual_path_);

// Grant access to the selected file to target extensions render view process.

- content::ChildProcessSecurityPolicy::GetInstance()->GrantPermissionsForFile(

- render_view_host()->GetProcess()->GetID(),

- full_path_,

- file_handler_util::GetReadWritePermissions());

+ content::ChildProcessSecurityPolicy::GetInstance()->GrantReadWriteFile(

+ render_view_host()->GetProcess()->GetID(), full_path_);

}

void FileBrowserHandlerInternalSelectFileFunction::Respond(bool success) {