Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1812893002: Fix the check for divide-by-zero in background image tiling (Closed)

Created:
4 years, 9 months ago by Stephen Chennney
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the check for divide-by-zero in background image tiling A recent patch changed the width used to find the amount of space when background-repeat is set to space, but did not update the corresponding zero check. This patch fixes it and adds a test for zero sized tiles in background painting. R=leviw@chromium.org BUG=595141, 594915 Committed: https://crrev.com/d146f1d1b21205841f8982b4fafc87b02b07aa29 Cr-Commit-Position: refs/heads/master@{#382058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/backgrounds/background-repeat-space-zero-tile-size.html View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/background-repeat-space-zero-tile-size-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812893002/1
4 years, 9 months ago (2016-03-17 15:43:37 UTC) #2
Stephen Chennney
I overlooked this on my previous rounding patch. Minor change. The test hits a divide-by-zero ...
4 years, 9 months ago (2016-03-17 15:43:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 17:01:46 UTC) #5
leviw_travelin_and_unemployed
lgtm
4 years, 9 months ago (2016-03-18 18:40:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812893002/1
4 years, 9 months ago (2016-03-18 18:41:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 20:03:23 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 20:06:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d146f1d1b21205841f8982b4fafc87b02b07aa29
Cr-Commit-Position: refs/heads/master@{#382058}

Powered by Google App Engine
This is Rietveld 408576698