Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1812853002: Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h (Closed)

Created:
4 years, 9 months ago by ahaas
Modified:
4 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Moved the ExternalReferenceTable class to src/external-reference-table.cc/.h The new location allows to add an external reference without requiring an lgtm from a snapshot/ owner. R=yangguo@chromium.org Committed: https://crrev.com/88309de15811967dcb2a9ea190fccf47eac859d9 Cr-Commit-Position: refs/heads/master@{#34858}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -442 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A src/external-reference-table.h View 1 chunk +50 lines, -0 lines 0 comments Download
A + src/external-reference-table.cc View 1 2 chunks +1 line, -63 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M src/snapshot/deserializer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/snapshot/serializer-common.h View 2 chunks +1 line, -33 lines 0 comments Download
M src/snapshot/serializer-common.cc View 1 1 chunk +1 line, -340 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/external-reference-check.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 9 months ago (2016-03-17 12:21:57 UTC) #1
Yang
lgtm. thanks!
4 years, 9 months ago (2016-03-17 13:02:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812853002/20001
4 years, 9 months ago (2016-03-17 13:10:17 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 13:14:17 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 13:14:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88309de15811967dcb2a9ea190fccf47eac859d9
Cr-Commit-Position: refs/heads/master@{#34858}

Powered by Google App Engine
This is Rietveld 408576698