Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1812833002: VideoCaptureAndroid: Disable YV12 support for XT1097 (Closed)

Created:
4 years, 9 months ago by magjed_chromium
Modified:
4 years, 9 months ago
Reviewers:
mcasas
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureAndroid: Disable YV12 support for XT1097 This CL adds XT1097 to COLORSPACE_BUGGY_DEVICE_LIST, which will cause it to use NV21 instead of YV12. BUG=595623, 577435 Committed: https://crrev.com/6185b7c9462a082c8552d324ceacb24c91fe2e43 Cr-Commit-Position: refs/heads/master@{#381964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/capture/video/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
magjed_chromium
Miguel - Please take a look.
4 years, 9 months ago (2016-03-17 12:14:21 UTC) #3
mcasas
LGTM Shouldn't we add a UMA or similar to track the amount of special devices?
4 years, 9 months ago (2016-03-17 17:25:41 UTC) #4
magjed_chromium
On 2016/03/17 17:25:41, mcasas wrote: > LGTM > > Shouldn't we add a UMA or ...
4 years, 9 months ago (2016-03-18 13:24:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812833002/1
4 years, 9 months ago (2016-03-18 13:25:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 14:43:06 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6185b7c9462a082c8552d324ceacb24c91fe2e43 Cr-Commit-Position: refs/heads/master@{#381964}
4 years, 9 months ago (2016-03-18 14:44:42 UTC) #11
mcasas
On 2016/03/18 13:24:45, magjed_chromium wrote: > On 2016/03/17 17:25:41, mcasas wrote: > > LGTM > ...
4 years, 9 months ago (2016-03-18 18:08:05 UTC) #12
magjed_chromium
4 years, 9 months ago (2016-03-21 12:07:01 UTC) #13
Message was sent while issue was closed.
On 2016/03/18 18:08:05, mcasas wrote:
> On 2016/03/18 13:24:45, magjed_chromium wrote:
> > On 2016/03/17 17:25:41, mcasas wrote:
> > > LGTM
> > > 
> > > Shouldn't we add a UMA or similar to track the amount
> > > of special devices?
> > 
> > I'm not sure if that statistics is interesting or useful. 
> 
> They are IMHO. Otherwise you'll never know how
> impactful your changes are and/or if you ever have
> the need or will to revert these changes, you won't
> have the information at hand and will need to land
> UMA stats there and then.
> 
> > I'm landing this CL without adding stats.
> 
> Please don't be so dismissive.
> 
> For instance, I see that there are 3 XT models already
> blacklisted, and now you added another one. How 
> can you tell what's the impact in relative terms of 
> each pseudo blacklisting?

I thought you were OK with landing this CL as is since you stamped it.

I think adding UMA stats for this is not particularly useful because we would
only track the devices we are already aware of that has this problem. Also, the
impact of changing from YV12 to NV21 is not very significant because the
performance of libyuv::I420Rotate() vs libyuv::NV12ToI420Rotate() is pretty
close. In fact, I'm ok with removing the black list altogether and switch to
always using NV21 instead - this is what we ended up doing in WebRTC.

If you feel strongly about adding UMA stats to track this, we can of course do
it, but I don't think it's worth it.

Powered by Google App Engine
This is Rietveld 408576698