Issue 181283003: Symbols for type cells.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181283003: Symbols for type cells. (Closed)

Created:
6 years, 10 months ago by mvstanton

Modified:
6 years, 9 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Symbols for type cells. We can make more efficient code to check against type cells in the future if we use symbols, guaranteed not to conflict with user code. Currently, the "symbols" are the hole and undefined. Undefined may come in from the outside. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19706

Patch Set 1 : Cleanup #

Patch Set 2 : Ports. #

Patch Set 3 : REBASE #

Patch Set 4 : REBASE #

Patch Set 5 : Addressed comments. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -105 lines)			Patch
M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/a64/builtins-a64.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/a64/code-stubs-a64.cc	View	1 2 3 4	9 chunks	+21 lines, -15 lines	0 comments	Download
M	src/a64/lithium-codegen-a64.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/arm/builtins-arm.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 2 3 4	8 chunks	+20 lines, -13 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/full-codegen.cc	View	1 2 3 4	1 chunk	+7 lines, -4 lines	0 comments	Download
M	src/heap.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View		2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2 3 4	5 chunks	+16 lines, -13 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/x64/builtins-x64.cc	View	1	2 chunks	+6 lines, -7 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2 3 4	5 chunks	+16 lines, -13 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Toon, Here is the use of symbols we discussed last week. PTAL, thanks! --Michael

6 years, 10 months ago (2014-02-26 12:29:33 UTC) #1

mvstanton

6 years, 9 months ago (2014-03-07 09:10:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r19706 (presubmit successful).

Expand Messages | Collapse Messages