LayoutTests/editing/execCommand/insert-ordered-list-crash.html - Issue 181283002: Fixing a crash in InsertListCommand.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/insert-ordered-list-crash.html

Issue 181283002: Fixing a crash in InsertListCommand. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1

	2 <body>

	3 <h5>

	4 aa

	5 <textarea></textarea>

	6 </h5>

	7 <dl>

	8 aa

	9 </dl>

	10 </body>

	11

	12 <script>
	Yuta Kitamura 2014/02/26 10:41:16 Technically, <script> should not appear after <bod Technically, <script> should not appear after <body> is closed. yoichio 2014/02/27 04:00:03 Done. Show quoted text On 2014/02/26 10:41:16, Yuta Kitamura wrote: > Technically, <script> should not appear after > <body> is closed. Done.
	13 document.addEventListener("DOMContentLoaded", function () {
	Yuta Kitamura 2014/02/26 10:41:16 You need to tell the layout test harness that this You need to tell the layout test harness that this test is asynchronous. To do that, you can make use of js-test.js (located at LayoutTests/resouces). You need to load that file, set \|window.jsTestIsAsync\| to true, and call \|finishJSTest()\| when the test really finishes. (Instead, you can manually call methods of testRunner, but I don't personally recommend this.) Take a look at a test I wrote yesterday <https://codereview.chromium.org/176863002/>. It uses iframe to load the HTML causing a crash, which I think is a little bit overkill, but at least should serve as a reference. yoichio 2014/02/27 04:00:03 Done. Show quoted text On 2014/02/26 10:41:16, Yuta Kitamura wrote: > You need to tell the layout test harness that > this test is asynchronous. To do that, you can make > use of js-test.js (located at LayoutTests/resouces). > You need to load that file, set \|window.jsTestIsAsync\| > to true, and call \|finishJSTest()\| when the test > really finishes. > > (Instead, you can manually call methods of testRunner, > but I don't personally recommend this.) > > Take a look at a test I wrote yesterday > <https://codereview.chromium.org/176863002/>. > It uses iframe to load the HTML causing a crash, > which I think is a little bit overkill, but at least > should serve as a reference. Done.
	14 var oSelection = window.getSelection();
	Yuta Kitamura 2014/02/26 10:41:16 nit: "oSelection" is awkward naming convention and nit: "oSelection" is awkward naming convention and uncommon in Blink. yoichio 2014/02/27 04:00:03 Done. Show quoted text On 2014/02/26 10:41:16, Yuta Kitamura wrote: > nit: "oSelection" is awkward naming convention > and uncommon in Blink. Done.
	15 document.execCommand("SelectAll", false);

	16 oSelection.deleteFromDocument();

	17 }, true);

	18

	19 var count = 0;

	20 document.addEventListener("DOMSubtreeModified", function () {

	21 count++;

	22 if (count < 3) {

	23 var oElement = event.srcElement;

	24 oElement.contentEditable = "true";

	25 oElement.innerHTML = '<div></div>';

	26 document.execCommand('InsertOrderedList', false, false);

	27 }

	28 }, false);

	29 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/insert-ordered-list-crash-expected.txt » ('j') | Source/core/dom/Range.cpp » ('J')