Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 1812823008: S390: Disable gcc generation of mul-add in cctests (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Disable gcc generation of mul-add in cctests Generated code performs distinct floating multiply and add/subtract operations. Tests fail when GCC uses mul-add to calculate the expected result since these instructions provide higher accuracy due to the lack of an intermediate round. R=machenbach@chromium.org, mbrandy@us.ibm.com, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/faaf8512bfef5300d0f79a997acf12cb1dcfc05e Cr-Commit-Position: refs/heads/master@{#34953}

Patch Set 1 #

Patch Set 2 : Rebased on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/cctest/cctest.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812823008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812823008/1
4 years, 9 months ago (2016-03-18 16:23:39 UTC) #2
john.yan
PTAL
4 years, 9 months ago (2016-03-18 16:23:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 16:47:26 UTC) #5
Michael Achenbach
lgtm
4 years, 9 months ago (2016-03-21 08:56:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812823008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812823008/1
4 years, 9 months ago (2016-03-21 12:32:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812823008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812823008/20001
4 years, 9 months ago (2016-03-21 14:17:33 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 16:42:55 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 16:43:43 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faaf8512bfef5300d0f79a997acf12cb1dcfc05e
Cr-Commit-Position: refs/heads/master@{#34953}

Powered by Google App Engine
This is Rietveld 408576698