[MD settings] update settings title bar

[MD settings] update settings title bar

This CL removes the title bar breadcrumbs, adds a search
icon (no search functionality yet), fixes title bar font
size.

BUG=589630
Committed: https://crrev.com/4cb5f090445ce77bd99fef03bf7bd43b03c3d6a1
Cr-Commit-Position: refs/heads/master@{#382047}

[dschuyler, 2016-03-17 21:20:40]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-03-17 21:21:27]

dschuyler@chromium.org changed reviewers:
+ tommycli@chromium.org

[tommycli, 2016-03-17 21:30:57]

lgtm --

The actual code is fine. Are we really getting rid of the breadcrumb??

https://codereview.chromium.org/1812823005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/1812823005/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:24: /*
NOTE(dschuyler):  The title-bar colors use non-MD colors.  These
nit: no need to mark this as your note in particular.

[tommycli, 2016-03-17 21:33:32]

Actually one more thing that blocks this patch:

You can now remove every 'subpageTitles' property in the settings_router.js
routes.

Other than that, lgtm

[dschuyler, 2016-03-18 01:22:55]

On 2016/03/17 21:33:32, tommycli wrote:
> Actually one more thing that blocks this patch:
> 
> You can now remove every 'subpageTitles' property in the settings_router.js
> routes.
> 
> Other than that, lgtm

Cool. The breadcrumb change was landed separately. In CL
https://codereview.chromium.org/1815523002/

[dschuyler, 2016-03-18 01:23:45]

https://codereview.chromium.org/1812823005/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/1812823005/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:24: /*
NOTE(dschuyler):  The title-bar colors use non-MD colors.  These
On 2016/03/17 21:30:56, tommycli wrote:
> nit: no need to mark this as your note in particular.

Done.

[tommycli, 2016-03-18 01:33:05]

Cool. These remaining changes still lgtm

[dschuyler, 2016-03-18 19:18:47]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:19:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812823005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812823005/40001

[commit-bot: I haz the power, 2016-03-18 19:25:52]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-18 19:27:25]

Description was changed from

==========
[MD settings] update settings title bar

This CL removes the title bar breadcrumbs, adds a search
icon (no search functionality yet), fixes title bar font
size.

BUG=589630
==========

to

==========
[MD settings] update settings title bar

This CL removes the title bar breadcrumbs, adds a search
icon (no search functionality yet), fixes title bar font
size.

BUG=589630

Committed: https://crrev.com/4cb5f090445ce77bd99fef03bf7bd43b03c3d6a1
Cr-Commit-Position: refs/heads/master@{#382047}
==========

[commit-bot: I haz the power, 2016-03-18 19:27:26]

Patchset 2 (id:??) landed as
https://crrev.com/4cb5f090445ce77bd99fef03bf7bd43b03c3d6a1
Cr-Commit-Position: refs/heads/master@{#382047}

[michaelpg, 2016-05-02 05:52:14]

https://codereview.chromium.org/1812823005/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/icons.html (right):

https://codereview.chromium.org/1812823005/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/icons.html:16: <g id="search" stroke="none"
stroke-width="1" fill="#ffffff">
It looks like you just took this from iron-icons.html and doubled all the
values. Why? Vectors scale, right? (Same question for the cancel icon, added
later.)

I'm asking because I'm consolidating icons via polyicon and I don't see the need
for this duplicate.