[chrome.displaySource] Add example extension

[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal: https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
Committed: https://crrev.com/9b0026dd68922519eaa52384102737ca975e2fb5
Cr-Commit-Position: refs/heads/master@{#381914}

[maksims (do not use this acc), 2016-03-17 12:00:20]

Description was changed from

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource API's.
The 'tabCast' extension creates a WiFi Display Session from the
captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

to

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource API's.
The 'tabCast' extension creates a WiFi Display Session from the
captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

[maksims (do not use this acc), 2016-03-17 12:00:20]

maksim.sisov@intel.com changed reviewers:
+ asargent@chromium.org, mikhail.pozdnyakov@intel.com

[maksims (do not use this acc), 2016-03-17 12:01:28]

Description was changed from

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource API's.
The 'tabCast' extension creates a WiFi Display Session from the
captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

to

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

[maksims (do not use this acc), 2016-03-17 12:01:59]

Please take a look

[Mikhail, 2016-03-17 13:10:01]

non-owner lgtm

[asargent_no_longer_on_chrome, 2016-03-17 19:24:29]

lgtm with a couple of minor comments

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js
(right):

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:5:
var SessionInfo = {};
nit: variable names should use camelCase. 

https://google.github.io/styleguide/javascriptguide.xml#Naming


Also, you can optionally add a prefix like 'g_' to indicate that this is a
global variable.

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:42:
function Start(sinkId) {
nit: function names should use camelCase

https://google.github.io/styleguide/javascriptguide.xml#Naming

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:45:
SessionInfo.SinkId = parseInt(sinkId);
nit: variable names should use camelCase

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:71:
SessionInfo.Stream = stream;
nit: variable names should use camelCase

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:96:
function Stop() {
nit: function names should use camelCase

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/examples/api/displaySource/tabCast/main.js
(right):

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/main.js:19: for
(sink of sinks) {
nit: please use 'let sink of sinks' to avoid leaving sink in global scope

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
File
chrome/common/extensions/docs/examples/api/displaySource/tabCast/manifest.json
(right):

https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/examples/api/displaySource/tabCast/manifest.json:15:
"persistent": true
Does this feature work with event pages, e.g. specifying "persistent": false
here? We're trying hard to migrate as many extensions as possible to this model,
and sometimes developers blindly copy examples without understanding everything,
so we prefer examples to use event pages whenever possible.

[maksims (do not use this acc), 2016-03-18 06:16:23]

Please review.

[maksims (do not use this acc), 2016-03-18 06:18:24]

On 2016/03/17 19:24:29, Antony Sargent wrote:
> lgtm with a couple of minor comments
> 
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
> File
> chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js
> (right):
> 
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:5:
> var SessionInfo = {};
> nit: variable names should use camelCase. 
> 
> https://google.github.io/styleguide/javascriptguide.xml#Naming
> 
> 
> Also, you can optionally add a prefix like 'g_' to indicate that this is a
> global variable.
> 
Fixed.
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:42:
> function Start(sinkId) {
> nit: function names should use camelCase
> 
> https://google.github.io/styleguide/javascriptguide.xml#Naming
> 
Fixed
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:45:
> SessionInfo.SinkId = parseInt(sinkId);
> nit: variable names should use camelCase
> 
>
Fixed as well 
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:71:
> SessionInfo.Stream = stream;
> nit: variable names should use camelCase
> 
> 
Done
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/background.js:96:
> function Stop() {
> nit: function names should use camelCase
> 
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
> File chrome/common/extensions/docs/examples/api/displaySource/tabCast/main.js
> (right):
> 
> 
Done
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
> chrome/common/extensions/docs/examples/api/displaySource/tabCast/main.js:19:
for
> (sink of sinks) {
> nit: please use 'let sink of sinks' to avoid leaving sink in global scope
> 
> 
Fixed.
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
> File
> chrome/common/extensions/docs/examples/api/displaySource/tabCast/manifest.json
> (right):
> 
>
https://codereview.chromium.org/1812813002/diff/1/chrome/common/extensions/do...
>
chrome/common/extensions/docs/examples/api/displaySource/tabCast/manifest.json:15:
> "persistent": true
> Does this feature work with event pages, e.g. specifying "persistent": false
> here? We're trying hard to migrate as many extensions as possible to this
model,
> and sometimes developers blindly copy examples without understanding
everything,
> so we prefer examples to use event pages whenever possible.

Yes, you are right. There is no need to run the script in background all the
time.

[Mikhail, 2016-03-18 07:17:35]

The CQ bit was checked by mikhail.pozdnyakov@intel.com

[Mikhail, 2016-03-18 07:17:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org, mikhail.pozdnyakov@intel.com
Link to the patchset: https://codereview.chromium.org/1812813002/#ps20001
(title: "Fixes according to the review")

[commit-bot: I haz the power, 2016-03-18 07:17:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812813002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812813002/20001

[commit-bot: I haz the power, 2016-03-18 08:57:49]

Description was changed from

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

to

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

[commit-bot: I haz the power, 2016-03-18 08:57:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 08:59:11]

Description was changed from

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107
==========

to

==========
[chrome.displaySource] Add example extension

Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.

API Proposal:
https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA

BUG=242107

Committed: https://crrev.com/9b0026dd68922519eaa52384102737ca975e2fb5
Cr-Commit-Position: refs/heads/master@{#381914}
==========

[commit-bot: I haz the power, 2016-03-18 08:59:13]

Patchset 2 (id:??) landed as
https://crrev.com/9b0026dd68922519eaa52384102737ca975e2fb5
Cr-Commit-Position: refs/heads/master@{#381914}