git_footers.py - Issue 1812803002: Gerrit git cl: fix change-id appending.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_footers.py

Issue 1812803002: Gerrit git cl: fix change-id appending. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: and the fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_footers.py

diff --git a/git_footers.py b/git_footers.py

index 1d4d4dd84099e5dcc95e78eb0870c10af3c437ae..a0f97f89e0cb6857c6ad1b6050a96a6bfbb70352 100755

--- a/git_footers.py

+++ b/git_footers.py

@@ -83,9 +83,13 @@ def add_footer_change_id(message, change_id):

if line == '' or line.isspace():

break

footer_lines.append(line)

+ else:

+ # The whole description was consisting of footers,

+ # which means those aren't footters.

Michael Achenbach 2016/03/17 12:29:05 nit: one t

tandrii(chromium) 2016/03/17 12:36:34 Done.

+ footer_lines = []

# footers order is from end to start of the message.

footers = map(parse_footer, footer_lines)

- if not all(footers):

+ if not footers or not all(footers):

lines.append('')

lines.append(change_id_line)

else:

« no previous file with comments | « no previous file | tests/git_footers_test.py » ('j') | no next file with comments »