Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812803002: Gerrit git cl: fix change-id appending. (Closed)

Created:
4 years, 9 months ago by tandrii(chromium)
Modified:
4 years, 9 months ago
Reviewers:
Bons, Michael Achenbach
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl: fix change-id appending. Special case when the change description has no footers, but looks like a footer. R=machenbach@chromium.org,andybons@chromium.org BUG=579176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299343

Patch Set 1 : Add test exposing the bug. #

Patch Set 2 : and the fix #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M git_footers.py View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M tests/git_footers_test.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812803002/1
4 years, 9 months ago (2016-03-17 11:30:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812803002/20001
4 years, 9 months ago (2016-03-17 11:34:41 UTC) #4
tandrii(chromium)
PTAL
4 years, 9 months ago (2016-03-17 11:34:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-17 11:37:12 UTC) #7
Michael Achenbach
lgtm https://codereview.chromium.org/1812803002/diff/20001/git_footers.py File git_footers.py (right): https://codereview.chromium.org/1812803002/diff/20001/git_footers.py#newcode88 git_footers.py:88: # which means those aren't footters. nit: one ...
4 years, 9 months ago (2016-03-17 12:29:05 UTC) #8
tandrii(chromium)
https://codereview.chromium.org/1812803002/diff/20001/git_footers.py File git_footers.py (right): https://codereview.chromium.org/1812803002/diff/20001/git_footers.py#newcode88 git_footers.py:88: # which means those aren't footters. On 2016/03/17 12:29:05, ...
4 years, 9 months ago (2016-03-17 12:36:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812803002/40001
4 years, 9 months ago (2016-03-17 12:36:40 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 12:38:57 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299343

Powered by Google App Engine
This is Rietveld 408576698