ES6: Object.setPrototypeOf(func, null) breaks instanceof

ES6: Object.setPrototypeOf(func, null) breaks instanceof

The way desugared instanceof called OrdinaryHasInstance if the lookup of
@@hasInstance failed was incorrect.

BUG=v8:4774
LOG=N

Committed: https://crrev.com/d47a4063c05f2a24ec93ddc48c930e08a444c994
Cr-Commit-Position: refs/heads/master@{#34855}

[mvstanton, 2016-03-17 08:55:14]

mvstanton@chromium.org changed reviewers:
+ rossberg@chromium.org

[mvstanton, 2016-03-17 08:55:14]

Hi Andreas,
I have a fix for a bug in the ES6 instanceof support, can you take a look?

There is a new runtime intrinsic. FWIW, in a follow-up CL I'll have optimizing
compiler support for it.
Thanks,
--Mike

[rossberg, 2016-03-17 12:29:54]

As discussed offline, I don't think the intrinsic would have been necessary,
since OrdinaryHasInstance is not a JS function that should ever be observable,
so you should be free to tweak its parameter conventions. But since it works,
LGTM.

[mvstanton, 2016-03-17 12:33:57]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2016-03-17 12:34:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812793002/1

[mvstanton, 2016-03-17 12:36:14]

Thanks very much!

I confess to liking being able to call the function in the same way on both
sides of the desugared then/else.
Best,
--Mike

[commit-bot: I haz the power, 2016-03-17 12:40:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 12:41:14]

Description was changed from

==========
ES6: Object.setPrototypeOf(func, null) breaks instanceof

The way desugared instanceof called OrdinaryHasInstance if the lookup of
@@hasInstance failed was incorrect.

BUG=v8:4774
LOG=N
==========

to

==========
ES6: Object.setPrototypeOf(func, null) breaks instanceof

The way desugared instanceof called OrdinaryHasInstance if the lookup of
@@hasInstance failed was incorrect.

BUG=v8:4774
LOG=N

Committed: https://crrev.com/d47a4063c05f2a24ec93ddc48c930e08a444c994
Cr-Commit-Position: refs/heads/master@{#34855}
==========

[commit-bot: I haz the power, 2016-03-17 12:41:15]

Patchset 1 (id:??) landed as
https://crrev.com/d47a4063c05f2a24ec93ddc48c930e08a444c994
Cr-Commit-Position: refs/heads/master@{#34855}