Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1812783002: Use GetRoutingIdForFrameOrProxy helper in BlinkAXTreeSource. (Closed)

Created:
4 years, 9 months ago by dcheng
Modified:
4 years, 9 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use GetRoutingIdForFrameOrProxy helper in BlinkAXTreeSource. BUG=none R=dmazzoni@chromium.org Committed: https://crrev.com/8ba3b6815d1d7247f8031d31cd90dcbbac8272b9 Cr-Commit-Position: refs/heads/master@{#381734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M content/renderer/accessibility/blink_ax_tree_source.cc View 3 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Something I noticed while reviewing the accessibility CLs.
4 years, 9 months ago (2016-03-17 08:50:27 UTC) #1
dmazzoni
lgtm Much cleaner, thanks
4 years, 9 months ago (2016-03-17 16:41:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812783002/1
4 years, 9 months ago (2016-03-17 16:41:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 17:02:06 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:03:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8ba3b6815d1d7247f8031d31cd90dcbbac8272b9
Cr-Commit-Position: refs/heads/master@{#381734}

Powered by Google App Engine
This is Rietveld 408576698