third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 1812763002: Pseudo and non pseudo elements should return correct computed content value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 1812763002: Pseudo and non pseudo elements should return correct computed content value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/hover-after-dom-delete.html ('K') | « third_party/WebKit/LayoutTests/inspector/elements/elements-panel-styles-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index c2262b9e55127ffd155c225031147f7ce0ffcf65..6ba12afef64bacf477ffb33e25b4bc4e7c349dc1 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2379,6 +2379,10 @@ PassRefPtrWillBeRawPtr<CSSValue> ComputedStyleCSSValueMapping::get(CSSPropertyID

case CSSPropertyTextOrientation:

return CSSPrimitiveValue::create(style.getTextOrientation());

case CSSPropertyContent:

+ if (style.hasPseudoElementStyle())

+ return cssValuePool().createIdentifierValue(CSSValueNormal);

+ if (!style.hasContent() && (style.styleType() == PseudoIdBefore || style.styleType() == PseudoIdAfter))

+ return cssValuePool().createIdentifierValue(CSSValueNone);

alancutter (OOO until 2018) 2016/03/22 09:35:23 I think you should be using styledNode->isPseudoEl

nainar 2016/03/23 02:50:49 Done.

return valueForContentData(style);

case CSSPropertyCounterIncrement:

return valueForCounterDirectives(style, propertyID);