third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 1812763002: Pseudo and non pseudo elements should return correct computed content value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1812763002: Pseudo and non pseudo elements should return correct computed content value (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('K') | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('j') | third_party/WebKit/Source/core/style/ComputedStyleConstants.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index adb73a602df75ebd5d50748f5c497c90c5da03b8..c69efb2559011fc867aad3d45691f35e596482d7 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -926,6 +926,16 @@ void ComputedStyle::setContent(QuoteType quote, bool add)

rareNonInheritedData.access()->m_content = ContentData::create(quote);

}

+void ComputedStyle::setContent(ElementContent elementContent, bool add)

+ if (add) {

+ appendContent(ContentData::create(elementContent));

+ return;

+ }

+ rareNonInheritedData.access()->m_content = ContentData::create(elementContent);

bool ComputedStyle::hasWillChangeCompositingHint() const

{

for (size_t i = 0; i < rareNonInheritedData->m_willChange->m_properties.size(); ++i) {