Pseudo and non pseudo elements should return correct computed content value

third_party/WebKit/Source/core/style/ContentData.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef ContentData_h
 #define ContentData_h
 
+#include "core/CSSValueKeywords.h"
 #include "core/style/CounterContent.h"
 #include "core/style/StyleImage.h"
 #include "wtf/OwnPtr.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace blink {
 
 class Document;
 class LayoutObject;
 class ComputedStyle;
 
 class ContentData : public NoBaseWillBeGarbageCollectedFinalized<ContentData> {
     USING_FAST_MALLOC_WILL_BE_REMOVED(ContentData);
 public:
     static PassOwnPtrWillBeRawPtr<ContentData> create(PassRefPtrWillBeRawPtr<StyleImage>);
     static PassOwnPtrWillBeRawPtr<ContentData> create(const String&);
     static PassOwnPtrWillBeRawPtr<ContentData> create(PassOwnPtr<CounterContent>);
     static PassOwnPtrWillBeRawPtr<ContentData> create(QuoteType);
+    static PassOwnPtrWillBeRawPtr<ContentData> create(CSSValueID);
 
     virtual ~ContentData() { }
 
     virtual bool isCounter() const { return false; }
     virtual bool isImage() const { return false; }
     virtual bool isQuote() const { return false; }
     virtual bool isText() const { return false; }
+    virtual bool isCSSValueID() const { return false; }
 
     virtual LayoutObject* createLayoutObject(Document&, ComputedStyle&) const = 0;
 
     virtual PassOwnPtrWillBeRawPtr<ContentData> clone() const;
 
     ContentData* next() const { return m_next.get(); }
     void setNext(PassOwnPtrWillBeRawPtr<ContentData> next) { m_next = next; }
 
     virtual bool equals(const ContentData&) const = 0;
 
@@ skipping 129 matching lines @@
     {
     }
 
     PassOwnPtrWillBeRawPtr<ContentData> cloneInternal() const override { return create(quote()); }
 
     QuoteType m_quote;
 };
 
 DEFINE_CONTENT_DATA_TYPE_CASTS(Quote);
 
+class CSSValueIDContentData final : public ContentData {
+    friend class ContentData;
+public:
+    CSSValueID cssValueID() const { return m_cssValueID; }
+    void setCSSValueID(CSSValueID cssValueID) { m_cssValueID = cssValueID; }
+
+    bool isCSSValueID() const override { return true; }
+    LayoutObject* createLayoutObject(Document&, ComputedStyle&) const override;
+
+    bool equals(const ContentData& data) const override
+    {
+        if (!data.isCSSValueID())
+            return false;
+        return static_cast<const CSSValueIDContentData&>(data).cssValueID() == cssValueID();
+    }
+
+private:
+    CSSValueIDContentData(CSSValueID cssValueID)
+        : m_cssValueID(cssValueID)
+    {
+    }
+
+    PassOwnPtrWillBeRawPtr<ContentData> cloneInternal() const override { return create(cssValueID()); }
+
+    CSSValueID m_cssValueID;

[alancutter (OOO until 2018), 2016/03/19 08:01:23]

How many different CSSValueIDs could be stored here? CSSValueIDs aren't
typically stored on ComputedStyle objects. Instead a separate enum is created in
ComputedStyleConstants.h with the restricted set of allowed values and a mapping
is added to CSSPrimitiveValueMappings.h.
You should do this here to maintain consistency with the rest of ComputedStyle
if the number of possible values is more than two.

[nainar, 2016/03/21 00:12:08]

Done.

+};
+
+DEFINE_CONTENT_DATA_TYPE_CASTS(CSSValueID);
+
 inline bool operator==(const ContentData& a, const ContentData& b)
 {
     return a.equals(b);
 }
 
 inline bool operator!=(const ContentData& a, const ContentData& b)
 {
     return !(a == b);
 }
 
 } // namespace blink
 
 #endif // ContentData_h