Pseudo and non pseudo elements should return correct computed content value

third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

 /*
  * Copyright (C) 2004 Zack Rusin <zack@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2011 Sencha, Inc. All rights reserved.
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ skipping 2361 matching lines @@
         if (style.getTextCombine() == TextCombineAll)
             return CSSPrimitiveValue::createIdentifier(CSSValueHorizontal);
     case CSSPropertyTextCombineUpright:
         return cssValuePool().createValue(style.getTextCombine());
     case CSSPropertyWebkitTextOrientation:
         if (style.getTextOrientation() == TextOrientationMixed)
             return CSSPrimitiveValue::createIdentifier(CSSValueVerticalRight);
     case CSSPropertyTextOrientation:
         return CSSPrimitiveValue::create(style.getTextOrientation());
     case CSSPropertyContent:
+        if (!style.hasContent()) {
+            if (style.styleType() == PseudoIdBefore || style.styleType() == PseudoIdAfter)
+                return cssValuePool().createIdentifierValue(CSSValueNone);
+            if (!styledNode->isPseudoElement())
+                return cssValuePool().createIdentifierValue(CSSValueNormal);

[alancutter (OOO until 2018), 2016/03/17 06:40:24]

Should this be guarded by !style.hasContent()?

[nainar, 2016/03/17 06:54:24]

As far as I understand from https://www.w3.org/TR/css3-content/#content -> if
the non pseudo element doesn't have text then we should set it to normal. Am I
wrong here?

+        }
         return valueForContentData(style);
     case CSSPropertyCounterIncrement:
         return valueForCounterDirectives(style, propertyID);
     case CSSPropertyCounterReset:
         return valueForCounterDirectives(style, propertyID);
     case CSSPropertyWebkitClipPath:
         if (ClipPathOperation* operation = style.clipPath()) {
             if (operation->type() == ClipPathOperation::SHAPE)
                 return valueForBasicShape(style, toShapeClipPathOperation(operation)->basicShape());
             if (operation->type() == ClipPathOperation::REFERENCE)
@@ skipping 362 matching lines @@
     case CSSPropertyAll:
         return nullptr;
     default:
         break;
     }
     ASSERT_NOT_REACHED();
     return nullptr;
 }
 
 } // namespace blink