Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1812753003: X87: [wasm] Int64Lowering of Int64Sub on ia32 and arm. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Int64Lowering of Int64Sub on ia32 and arm. port 33c08596e10f8ed64f8097049ac6c424c0616ee1 (r34808) original commit message: Int64Sub is lowered to a new turbofan operator, Int32SubPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the subtraction. The implementation is very similar to the implementation of Int64Add. @v8-arm-ports: please take a careful look at the implementation of sbc in the simulator BUG= Committed: https://crrev.com/831add808dcc9429b48719b9e45e9ab85c27c084 Cr-Commit-Position: refs/heads/master@{#34844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-17 07:59:18 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-17 08:10:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1812753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1812753003/1
4 years, 9 months ago (2016-03-17 08:12:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 08:35:03 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 08:37:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/831add808dcc9429b48719b9e45e9ab85c27c084
Cr-Commit-Position: refs/heads/master@{#34844}

Powered by Google App Engine
This is Rietveld 408576698